Feat/duplication #1180
Feat/duplication #1180
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
seballot
force-pushed
the
feat/duplication
branch
from
a9c4a8b
to
301df7f
Compare
| }, $pages); | ||
|
|
||
| return $pages; | ||
| } | ||
|
|
||
| private function duplicate($sourceTag, $destinationTag): bool |
There was a problem hiding this comment.
?? un code de test? à supprimer non?
There was a problem hiding this comment.
non je voulais creer une methode dans le PageManager, mais work in progress
There was a problem hiding this comment.
Yo !
top tout ça !
J'ai fait des petites remarques pour la forme, mais c'est pas du tout bloquant. y'a 2/3 commentaires à fixer cependant
J'ai poussé les petit fix, plus un passage de linter (ils étaient pas en place quand tu as commencé le boulot sur cette branche)
| @@ -1180,4 +1180,11 @@ function ($attributeName) { | |||
|
|
|||
| return $entriesIds; | |||
| } | |||
|
|
|||
| private function duplicate($sourceTag, $destinationTag): bool | |||
There was a problem hiding this comment.
pareil methode de service non existante encore..
| @@ -36,6 +36,11 @@ | |||
| </td> | |||
| <td>{{ key }}</td> | |||
| <td> | |||
| {% if list.canDuplicate %} | |||
| <a class="btn btn-default btn-xs" href="{{ url({ params: { vue: 'listes', action: 'duplicate', idliste: key }}) }}"> | |||
| <i class="far fa-clone"></i> | |||
There was a problem hiding this comment.
On est d'accord c'est pas encore implémenté la duplication de liste? en tout cas chez moi ça marche pas :)
|
Ok merci pour cette revue, je vais tout prendre en compte, sauf peut etre la re--ecriture jquery vers vuejs, je ferai que si j'ai du temps. |
mrflos
force-pushed
the
feat/duplication
branch
2 times, most recently
from
6715402
to
14b7d39
Compare
mrflos
force-pushed
the
feat/duplication
branch
2 times, most recently
from
b989037
to
c38df35
Compare
| data: $('#form-duplication').serialize() | ||
| }).done((d) => { | ||
| if (btnAction === 'open') { | ||
| document.location = `${shortUrl}/?${d.newTag}` |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
| if (btnAction === 'open') { | ||
| document.location = `${shortUrl}/?${d.newTag}` | ||
| } else if (btnAction === 'edit') { | ||
| document.location = `${shortUrl}/?${d.newTag}/edit` |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
mrflos
force-pushed
the
feat/duplication
branch
from
6ed0aef
to
753c915
Compare
mrflos
force-pushed
the
feat/duplication
branch
from
38214cd
to
f03ec43
Compare
Description of pull request / Description de la demande d'ajout
90% finished feature of duplication of pages/lists in same wiki or to external wikis
After rebase from doryphore-dev i had some strange bugs, i tried to fix them, hopefully i got them all.
You can test the duplication feature on another wiki by giving url local dev url as url for duplication (it will use the api roads instead of the controller).
Sorry for the quite big codebase changes...
Edit: i can see what when wrong : there are two other beta-features included : an image optimizer, and extra-fields feature (that add comments and reactions to bazarlist if needed)
I will check if everything is working as expected, as it should also be reviewed, or do you prefer separated PRs ?